Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP: Fix p_ntp_time_fmt() using epoch 1/epoch 2 convention (RFC 4330) #1164

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

fxlb
Copy link
Member

@fxlb fxlb commented Apr 2, 2024

Moreover:
Update the error message, replace
"[Time is too large to fit into a time_t]"
by
"[timestamp overflow]".
Same as in ts_date_hmsfrac_print() and ts_unix_print().

Fix indentation.

Update 5 test outputs and processings, based on skip_time_t_not (64).

@fxlb fxlb marked this pull request as draft April 2, 2024 11:27
@fxlb
Copy link
Member Author

fxlb commented Sep 20, 2024

More tests to do with 64-bit time_t.

@fxlb fxlb force-pushed the test_ntp branch 2 times, most recently from 2a05f4c to 581a3e7 Compare March 24, 2025 17:38
@fxlb fxlb changed the title [TEST ONLY] NTP: test a p_ntp_time_fmt() update NTP: Fix p_ntp_time_fmt() using epoch 1/epoch 2 convention (RFC 4330) Mar 24, 2025
@fxlb fxlb force-pushed the test_ntp branch 3 times, most recently from 72f9a2e to 28d6a66 Compare March 24, 2025 18:20
Moreover:
Update the error message, replace
"[Time is too large to fit into a time_t]"
by
"[timestamp overflow]".
Same as in ts_date_hmsfrac_print() and ts_unix_print().

Fix indentation.

Update 5 test outputs and processings, based on skip_time_t_not (64).
@fxlb fxlb marked this pull request as ready for review March 24, 2025 20:32
@fxlb fxlb merged commit 801a7c1 into the-tcpdump-group:master Mar 25, 2025
20 checks passed
@fxlb fxlb deleted the test_ntp branch March 25, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant